Fix Redis Sentinel support #7365
Conversation
server/core/lib/redis.ts
Outdated
| connectionName, | ||
| connectTimeout, | ||
| enableTLSForSentinelMode: CONFIG.REDIS.SENTINEL.ENABLE_TLS, | ||
| sentinelPassword: CONFIG.REDIS.AUTH, |
There was a problem hiding this comment.
I think the admin should provide the password for each sentinel no? Because you can set a specific password for each of them?
There was a problem hiding this comment.
Using different password for each sentinel isn't recommended (from High availability with Valkey Sentinel (and redis has the exact same page which I guess Valkey copied)):
This means that you will have to configure the same requirepass password in all the Sentinel instances. This way every Sentinel can talk with every other Sentinel without any need to configure for each Sentinel the password to access all the other Sentinels, that would be very impractical.
But what could be interesting is providing a different password for sentinel and for redis.
I guess I can make somthing like config.redis.auth is used to connect to redis servers and add a new parameter config.redis.sentinel.auth used for sentinel connections.
There was a problem hiding this comment.
Yes please! Prefer config.redis.sentinel.password (we'll rename config.redis.auth to config.redis.password in the future)
2 participants
Description
Fix Redis Sentinel support by fixing names and adding the password for the redis access alongside the password for sentinel.
Related issues
#7364
Has this been tested?
Directly changed the files in production